send_request should not update _default_headers#439
Open
tanoda wants to merge 1 commit intookta:masterfrom
Open
send_request should not update _default_headers#439tanoda wants to merge 1 commit intookta:masterfrom
tanoda wants to merge 1 commit intookta:masterfrom
Conversation
Author
|
In addition, _default_headers shares its dict instance with the RequestExecutor. okta-sdk-python/okta/http_client.py Line 24 in 597908a okta-sdk-python/okta/request_executor.py Line 70 in 597908a So RequestExecutor.create_request also adds the latest headers. okta-sdk-python/okta/request_executor.py Line 123 in 597908a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HTTPClient.send_requestupdates its _default_headers with headers from its parameter.I don't believe this is the thing that you want.